[version_1] Set correct ownership if qb_ipcs_connection_auth_set() has been used #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
The CI failure comes from a linting error that appears to be unrelated to the proposed patch, see #374. |
|
It looks good to me. Can you fix the split errors please? it's just a question of changing the line in lib/Makefile.am from " 2 code warnings" to " 3 code warnings", then I'll pull it. Thanks! |
When qb_ipcs_connection_auth_set() has been used, the ownership of the temp directory initially set by handle_new_connection() must be updated as well.
|
Thanks, I didn't realise the linting error was due to the ignored return value of |
|
Thanks for that. The RPM build fail is 'normal' so that I'm not going to worry about! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #381 in case there is another 1.0.* release.